Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Single signer verification functions for multisig #8

Merged
merged 6 commits into from
Jan 18, 2023

Conversation

3ierratango
Copy link
Contributor

@3ierratango 3ierratango commented Dec 29, 2022

Changelog:

  • Add new verification functions that does not check for quorum signatures

Copy link
Contributor

@naiemk naiemk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a new verify method break the tryVerifyDigestWithAddress‍‍ method into two:

  • tryVerifyDigestWithAddress
  • tryVerifyDigestWithAddressNoMinSigCheck

tryVerifyDigestWithAddress will call the NoMinSigcheck and after check the following:

require(
            signatures.length >= q.minSignatures,
            "MSC: not enough signatures"
        );

tryVerifyDigestWithAddressNoMinSigCheck is only renamed from tryVerifyDigestWithAddress with above lines removed

contracts/signature/MultiSigCheckable.sol Outdated Show resolved Hide resolved
contracts/signature/MultiSigCheckable.sol Outdated Show resolved Hide resolved
contracts/signature/MultiSigCheckable.sol Outdated Show resolved Hide resolved
contracts/signature/MultiSigCheckable.sol Outdated Show resolved Hide resolved
@naiemk
Copy link
Contributor

naiemk commented Jan 18, 2023

Closing in the favor of this PR: #10

I made some changes. First, kept the library API unchanged. There are some other contracts using this lib. Second, removed the signle signer check method because it is not really checking for single signer, it is checking for multi-signer without count validation

@naiemk naiemk merged commit 6149306 into ferrumnet:develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants