Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IronVestAdminRequried this is the same contract as our audited iron… #18

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

SibghatUllah1997
Copy link
Contributor

@SibghatUllah1997 SibghatUllah1997 commented Aug 2, 2023

  • In these contracts emergencyWithdrawal can withdraw any tokens regardless of condition

  • IronVestAdminRequried: This is the same contract as our audited ironvest, but the difference is that we are now going to deploy the contract using the factory pattern. In the previous implementation, the deployer was the default admin, but here we have to take it as a parameter. This contract file and name are separated from the audited one.

  • There is a contract with the name of IronVestDeployer. By using this contract, we can deploy IronVestAdminRequried and our extended version of the contract.

  • There is a contract named IronVestExtended.sol (in a separate directory), which is supposed to have the functionality of updating the beneficiary address. This contract is inheriting another contract named IronVestPreCheck.sol. This contract is a read-only contract, and we only need to deploy it once. We can use it as many times as we want. This contract is supposed to check some preconditions for executing a function.

  • Lastly, for IronVestExtended.sol deployment, we need to activate optimization of 200 points.
    ```ct with the name of IronVestPreCheck.sol this contract is read only contract we just need to deploy this contract once and we can use it as many time as we want this contract supposed to check some preCondition for executing a function

  • Laslty for IronVestExtended.sol deployment we need to active optimization of 200 points

…vest but the difference is that we are now going to deploy contract by factory pattern in previous implementation deployer is the default admin but here we have to take it as param. This contact file and name is seperated from audited on
…awl so admin can withdraw any tokens stuck in contract
…awl so admin can withdraw any tokens stuck in contract
@taha-abbasi taha-abbasi merged commit 8e990bb into ferrumnet:develop Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants