Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies for Yeoman #57

Closed
wants to merge 5 commits into from
Closed

Conversation

Iristyle
Copy link
Contributor

Libjpeg-turbo 1.2.1
PhantomJS 1.6.1
OptiPNG 0.7.1

Adds itself to PATH (useful for Yeoman)
Includes Icon
During install, adds to PATH (for Yeoman)
- Installs from executable on SourceForge - x86 or x64 based on OS
- Adds bin directory to PATH (useful for Yeoman)
- Publishes install status
@Iristyle
Copy link
Contributor Author

Just let me know if calling cinst for Compass should instead be a call to another cmdlet.

$url = 'http://prdownloads.sourceforge.net/optipng/optipng-0.7.1-win32.zip?download'
Install-ChocolateyZipPackage $package $url $unzipPath

Install-ChocolateyPath $unzipPath
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One might prefer moving this to a bin_dir location.

Simple wrapper around gem install compass -v 0.12.2
@Iristyle
Copy link
Contributor Author

Ok -- Compass added, and reworked Yeoman to ref Compass, and therefore Ruby indirectly.

@ferventcoder
Copy link
Owner

nice... let me get these up.. :D

@ferventcoder
Copy link
Owner

Is there a reason to depend on a particular version of some of these libraries?

Also, why gitextensions?

@Iristyle
Copy link
Contributor Author

Yeoman requires PhantomJS >= 1.6 and Ruby >= 1.87... presumably the current versions of optipng and libjpeg that I have there. I was simply being explicit about having the "at least" versions, according to the Nuspec ref.

http://docs.nuget.org/docs/reference/versioning#Specifying_Version_Ranges_in_.nuspec_Files

The intent was that if you locally already had, say, Ruby 1.9 installed, you'd be fine, but if you had 1.84, you'd be bumped to 1.87.

I'm not sure if Chocolatey varies from the standard Nuget version spec? In reality, 'latest' would be fine if the package needed to be installed, in the case of Ruby... but then an empty version string wouldn't guarantee that you have a minimum 1.87 if you only had 1.84 installed, would it? This would be clearer if it supported a tilde version specifier like NPM, but I digress...

Yeoman may have packages it needs to install using Git -- the Bower pkg manager its using can pull from Git repos for instance. Git extensions could be replaced with msysgit -- however, you've deprecated that ;0 I personally find the new Git for Windows (not be confused with GitHub for Windows) UI to be total crap (along with TortoiseGit, which is also junk). Git for Windows will mess with Git Extensions explorer integration if you already have that installed.

@ferventcoder
Copy link
Owner

Deprecated for GIT. You want me to put that one in there?

Installs deps Ruby, Git, nodejs.isntall, libjpeg-turbo, OptiPNG
PhantomJS

Installer launches the compass installer, and npm installs Yeoman
@Iristyle
Copy link
Contributor Author

I don't know what you mean.. but I switched it to msysgit.

@Iristyle
Copy link
Contributor Author

Or are you saying this should be git.commandline instead?
http://chocolatey.org/packages/git.commandline

My only issue with these commandline variants you have for things, is that they can at least theroetically mess with things that may have already been installed via a exe / msi / etc

@ferventcoder
Copy link
Owner

Just git.

@ferventcoder
Copy link
Owner

I made some other changes so don't worry about updating this guy.

@Iristyle
Copy link
Contributor Author

It's the install of that Git package (that includes Git-Gui) that seems to mess with Git Extensions...

@Iristyle
Copy link
Contributor Author

And adds a bunch of additional context menu crud to launch crappy variants of the same Git Extension tools (the commit window that comes with Git Gui is particularly offensive)

@ferventcoder
Copy link
Owner

In and done.

Git install shouldn't mess with git extensions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants