Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for SearchPictograms and EditBoardCell viewmodels and local data storage #57

Merged

Conversation

jmgjmg
Copy link
Collaborator

@jmgjmg jmgjmg commented Jun 26, 2023

New Pull Request

Description

Added unit tests for SearchPictograms EditBoardCell viewmodels.
Uses Turbine library to check dynamic updates of UIState flow.
Added tests for Dao and local data source under AndroidTest

Fixes

It fixes issues #56 and #61

@jmgjmg jmgjmg added the enhancement New feature or request label Jun 26, 2023
@jmgjmg jmgjmg self-assigned this Jun 26, 2023
Copy link
Owner

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM 👍🏻

@jmgjmg jmgjmg linked an issue Jul 10, 2023 that may be closed by this pull request
@jmgjmg jmgjmg removed a link to an issue Jul 10, 2023
@jmgjmg jmgjmg linked an issue Jul 10, 2023 that may be closed by this pull request
@jmgjmg jmgjmg changed the title Unit tests for SearchPictograms and EditBoardCell viewmodels Tests for SearchPictograms and EditBoardCell viewmodels and local data storage Jul 10, 2023
Copy link
Collaborator

@cjimenezsanchez cjimenezsanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job with the testing!

@cjimenezsanchez cjimenezsanchez merged commit 2739896 into develop Jul 14, 2023
3 checks passed
@cjimenezsanchez cjimenezsanchez deleted the test/viewModels_searchPictograms_editBoardCell branch July 14, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing local storage tests
3 participants