-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fine tuning main dashboard and list #60
Feature/fine tuning main dashboard and list #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good refactoring, I have commented a small suggestion, the rest of the code looks good!
android:layout_height="match_parent" | ||
android:paddingStart="10dp" | ||
android:paddingTop="10dp" | ||
android:paddingEnd="10dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use android:paddingHorizontal="10dp"
instead of android:paddingStart="10dp"
and android:paddingEnd="10dp"
😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! you also have the option of using paddingVertical
you can check here
New Pull Request
Description
Review some parts of
MainDashboardFragment
andViewModel
and finishListDashboard
feature implementation.PD. No test added yet. Waiting on other PR and Tuesday's synch to identify missing tests.