-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit cell when creating new board #62
Conversation
@@ -30,7 +30,14 @@ class EditDashboardFragment : Fragment() { | |||
private val viewModel: EditDashBoardViewModel by viewModel { | |||
parametersOf(args.dashBoardId) | |||
} | |||
private val dashboardCellsAdapter = DashboardCellsAdapter { } | |||
private val dashboardCellsAdapter = DashboardCellsAdapter { cell -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for consistency i would move this to an state holder as the in the other fragments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment about navigation on state holder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the real one
New Pull Request
Description
Connect the dashboard editing flow to finish with the cell editing and display on the dashboard.
Fixes
n/a