Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example .desktop file. #40

Merged
merged 5 commits into from
Dec 10, 2023
Merged

Added example .desktop file. #40

merged 5 commits into from
Dec 10, 2023

Conversation

CupricReki
Copy link
Contributor

I created a .desktop file for the GUI. Not sure if this helps you or not. Might want to add a German translation for the comment Comment[de-DE] The mouse-icon.svg icon should be in put into /usr/share/icons/hicolor/scalable/apps.

You might also consider making the icon more dark mode friendly.
image

I'm working towards creating a PKGBUILD for the Arch User Repository.

@feschber
Copy link
Owner

feschber commented Dec 1, 2023

Two things:

  1. As of right now this will not launch, if ~/.config/lan-mouse does not exist because of the Path directive.
    I just merged Respect XDG_CONFIG_HOME for config.toml location #41 so this workaround is not necessary anymore.

  2. It would be great, if you could add installation instructions to the README. You mentioned that you put the icon under /usr/share/icons/hicolor and I'm guessing that you put the desktop file under /usr/share/applications as well.

This is generally not recommended for manual installations because /usr should only be modified by the package manager.

For the manual installation instructions I would prefer either (or both) of the following options:

  • Either /usr/local/share/icons/... and /usr/local/share/applications for system wide installation.
  • Or $HOME/.local/share/icons/... and $HOME/.local/share/applications for a user installation.

A small section about putting the downloaded / compiled lan-mouse binary into a directory that's is in the PATH would also be good for less experienced users.

I will gladly accept a PKGBUILD for the AUR, however I would prefer to wait with publishing until #33 is merged (so that all major desktops are supported).

Copy link
Owner

@feschber feschber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a minute? I could update the README myself as well :)

lan-mouse.desktop Outdated Show resolved Hide resolved
lan-mouse.desktop Outdated Show resolved Hide resolved
lan-mouse.desktop Show resolved Hide resolved
lan-mouse.desktop Outdated Show resolved Hide resolved
@feschber feschber merged commit 5c8ea25 into feschber:main Dec 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants