Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role admin/viewer #128

Closed
fescobar opened this issue Sep 14, 2020 · 6 comments
Closed

Add role admin/viewer #128

fescobar opened this issue Sep 14, 2020 · 6 comments
Labels
new feature New Feature released Released

Comments

@fescobar
Copy link
Owner

Add new roles to differentiate views.
Related to fescobar/allure-docker-service-ui#6

@fescobar fescobar added new feature New Feature backlog Backlog labels Sep 14, 2020
@fescobar
Copy link
Owner Author

fescobar commented Dec 2, 2020

@nodlesh FYI

@fescobar
Copy link
Owner Author

@nodlesh
This feature was released!

To see reflected the new feature Admin/Viewer roles use any version of API container from 2.13.7 and use any version of UI container from 7.0.1

allure-docker-service (API)
https://github.com/fescobar/allure-docker-service/releases/tag/v2.13.7

allure-docker-service (UI)
https://github.com/fescobar/allure-docker-service-ui/releases/tag/v7.0.1

Thank you for your suggestions.

@fescobar fescobar added the released Released label Dec 28, 2020
@fescobar fescobar closed this as completed Jan 2, 2021
@nodlesh
Copy link

nodlesh commented Jan 7, 2021

Does this enhancement allow for no security on the HTML reports? I want to secure the Admin and the API, but not the reports themselves. From reading the docs it seems like the viewer role still needs a username and password. My usecase is to let the public see the reports with no barriers to entry. Thanks.

@fescobar
Copy link
Owner Author

fescobar commented Jan 7, 2021

@nodlesh if you enable security I need to protect the endpoints. For that reason, you need to login as a viewer user.

I could add a way to disable that and let you access directly to reports. Let me think about that and I will create another ticket.
Thank you.

@nodlesh
Copy link

nodlesh commented Jan 7, 2021

Thanks.

@fescobar
Copy link
Owner Author

@nodlesh I've created this ticket with your requirement #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New Feature released Released
Projects
None yet
Development

No branches or pull requests

2 participants