Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Make format less US-centric #2

Closed
Zarkonnen opened this issue Aug 27, 2012 · 3 comments
Closed

Suggestion: Make format less US-centric #2

Zarkonnen opened this issue Aug 27, 2012 · 3 comments

Comments

@Zarkonnen
Copy link

A number of elements in this are very US-centric, which will ultimately pose a problem to widespread adoption:

  • There is no way to supply values in more than one language.
  • 'zip' and 'state' are Americanisms: some countries have one or the other, or call it different things (post code, department), and some countries have neither.
  • Price range is very subjective and again notated in $. What are the minimum/maximum values?
  • Opening times use AM/PM format, which again is confusing for non-Americans. Consider using 24 hour time format instead, or make it clear that both formats should be supported by parsers.
  • Payment: 'credit card' is too vague - does it take Visa/Amex/etc? Does it take debit cards? Does it take some funky local currency like Ithaca hours or WIR?
@fesja
Copy link
Owner

fesja commented Aug 27, 2012

Thanks for the suggestion David, I agree with all of them.

There is no way to supply values in more than one language.

I thought about that and I still don't which is the best option.

Name: Prado Museum
[ES] Name: Museo del Prado

What do you think?

'zip' and 'state' are Americanisms: some countries have one or the other, or call it different things (post code, department), and some countries have neither.

I know, but what I wanted to avoid is to complicate the parser. Because in Spain, states are called Comunidades. In other countries Departments, in other even countries. Not sure which is the best option.

Price range is very subjective and again notated in $. What are the minimum/maximum values?

This is very subjective and it depends on the restaurant/hotel. I believe they should be honest about themselves, because if they put $ and it's really expensive they are not going to receive clients or they are going to expend way too little. But we could remove this fields as it's not objetive.

Opening times use AM/PM format, which again is confusing for non-Americans. Consider using 24 hour time format instead, or make it clear that both formats should be supported by parsers.

Agree

Payment: 'credit card' is too vague - does it take Visa/Amex/etc? Does it take debit cards? Does it take some funky local currency like Ithaca hours or WIR?

Hehe. What about being a list of payments methods separated my commas? So it can be:

Payment: Cash, Visa, Mastercard, Ithaca hours

And then each website can recognize the payments they are showing.

@Zarkonnen
Copy link
Author

I think prefixing the keys like that could work. I think in the rest of the cases it's more a question of defining the gamut of valid values: for example, it's fine to use both AM/PM and 24 hrs formats as long as the parsers know either might crop up.

@fesja
Copy link
Owner

fesja commented Aug 27, 2012

added to the proposal!

@fesja fesja closed this as completed Aug 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants