Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in Dockerfile #10

Open
sharmarajdaksh opened this issue Sep 29, 2020 · 2 comments
Open

Improvements in Dockerfile #10

sharmarajdaksh opened this issue Sep 29, 2020 · 2 comments

Comments

@sharmarajdaksh
Copy link

sharmarajdaksh commented Sep 29, 2020

Hi,
I landed on your repo while searching for a solution to mask Aadhaar numbers in images, and even though Pyradox wasn't exactly a perfect solution, it was a great starting point. I'd like to thank you for that.
While updating the code and making changes to fit my use case, I realized that rebuilds of the Docker image were taking way more than they should. I realized that the Dockerfile wasn't exactly well configured for efficient rebuilds, so I modified the Dockerfile to be much better organized and to allow faster rebuilds when changes in code are made, without any dependencies being affected.
I wanted to know if you would be willing to accept a PR with the Dockerfile changes?

@festivitymishra
Copy link
Owner

Hi @sharmarajdaksh, Glad that the Pyradox project was of use to you. Please feel free to send the PR. Also, we are open to contributions if you would wish to add in more features. Currently, we have improved the image-preprocessing, the code for which is yet to be merged. Will do that soon. Also, check out the web-app for this project: https://github.com/festivitymishra/PyraDox-frontend

Thanks!

@sharmarajdaksh
Copy link
Author

Hi, thanks, I'll raise the PR! I'll also be watching and try to help wherever I can.

sharmarajdaksh added a commit to sharmarajdaksh/PyraDox that referenced this issue Oct 8, 2020
- Rearranged Dockerfile commands to install dependencies only when
dependencies change.
  - As it was earlier, the pip dependencies were reinstalled after every
  change in code (.py) files, which was completely unnecessary

- Added Cmake as an OS dependency as builds were failing without it

Closes festivitymishra#10
@github-staff github-staff deleted a comment from naudachu May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants