Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple ALSA and PulseAudio audio modules #33

Merged
merged 2 commits into from Sep 15, 2020

Conversation

zeehio
Copy link
Contributor

@zeehio zeehio commented Aug 29, 2020

On Debian (and other distributions), the package maintainers need to compile both ALSA and PulseAudio support, so users can choose the audio module they prefer. Before this PR, speech-tools is built with either ALSA or PulseAudio support, but not both. With this pull request, PulseAudio becomes an independent audio module (like esdaudio).

This PR is improved from https://salsa.debian.org/tts-team/speech-tools/-/blob/master/debian/patches/pulseaudio_and_alsa.diff

On Debian and other distributions, the package maintainers need
to compile both ALSA and PulseAudio support, so users can choose
the audio module they prefer.

This decouples LINUX_AUDIO and PULSE_AUDIO so they can both be
compiled simultaneously.
zeehio added a commit to zeehio/festival-1 that referenced this pull request Aug 30, 2020
Copy link
Collaborator

@lenzo-ka lenzo-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenzo-ka lenzo-ka merged commit a3d7234 into festvox:master Sep 15, 2020
@zeehio zeehio deleted the feat-allow-pulse-and-alsa branch October 24, 2020 12:53
@orowith2os orowith2os mentioned this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants