Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for fees in NativeBalanceChange events #89

Closed
bryanchriswhite opened this issue Sep 13, 2022 · 0 comments · Fixed by #123
Closed

Account for fees in NativeBalanceChange events #89

bryanchriswhite opened this issue Sep 13, 2022 · 0 comments · Fixed by #123
Labels
C-bug Category: Something isn't working

Comments

@bryanchriswhite
Copy link

Background

@daeMOn63 pointed out in #88:

Also worth noting that fee spendings are actually not tracked by coin_spent events for some reason. I've asked on cosmos Discord to see if this is intended

and

On tracking fees, there's an event tracking the fees we could grab, but it's been added in cosmos-sdk v0.45.8, so we'll have to wait for our chain to use this version to have it. (see: https://github.com/cosmos/cosmos-sdk/blob/v0.45.8/x/auth/ante/fee.go#L121-L123)

Acceptance Criteria

  1. NativeBalanceChange events include the fee for the transaction to which they're related in their amount.
  2. An end-to-end test covers this behavior.

Proposal

Perhaps while we wait for cosmos-sdk v0.45.8, we can reference fees from the related transaction in the event handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants