Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize feature name #15

Merged
merged 1 commit into from May 22, 2023
Merged

Conversation

eduardoborba
Copy link
Contributor

The feature's name isn't escaped properly in the "Do you really want to delete" confirmation dialog. When the user clicks "Delete", the page will run the XSS from the feature name.

Example: http://localhost:9292/features/'+alert(1)+'

Screen Shot 2023-01-26 at 11 43 09

@eduardoborba
Copy link
Contributor Author

hey @fl-slava @reneklacan @Bartuz,
We have tried to contact you through other forms and haven't heard back from you, so we went ahead and requested a CVE ID for this vulnerability and are planning to disclose this to the public soon. Could you please take a look at this PR and help us push the fix in the next rollout-ui version for the other users?

@nielsenramon
Copy link
Member

We have tried to contact you through other forms and haven't heard back from you

@eduardoborba Mind if I ask how and where you contacted us? Only email we got was 4 hours ago from another company.

@Antti
Copy link
Member

Antti commented May 22, 2023

Thank you @eduardoborba !

@Antti Antti merged commit 713d9c2 into fetlife:master May 22, 2023
@eduardoborba
Copy link
Contributor Author

@nielsenramon I've tried to reach to some of the maintainers by email, using my work email. Plus the PR was open here since March. I'm glad that someone else was also pushing to get the fix accepted.

Thank you! @Antti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants