Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis-rb 5.0+ compatibility #166

Closed
nevans opened this issue Nov 3, 2022 · 9 comments
Closed

Redis-rb 5.0+ compatibility #166

nevans opened this issue Nov 3, 2022 · 9 comments
Assignees

Comments

@nevans
Copy link

nevans commented Nov 3, 2022

Currently, rollout depends on redis ~> 4.0, but redis 5.0 was released on August 29th.

The last several versions of the redis gem added many deprecation warnings for the various API changes, as well as the ability to raise errors instead of log warnings. So, if there's good test coverage, it might be fairly straightforward to make any necessary changes for the upgrade.

@nevans
Copy link
Author

nevans commented Nov 3, 2022

sorry for the quick report without even an attempt at a PR. If no one else sends in a PR for this in the next couple of weeks, I'll probably make time for it myself. :)

@jnunemaker
Copy link

If its helpful, here are the changes we had to make to flipper to support redis 5. I assume they'd be similar for rollout. Might save some time.

@jcagarcia
Copy link

There is any plan to support redis-rb 5 in a short time? I was thinking on doing a PR for this but I can see two PRs #167 and #168 but not even reviewed. Is this project receiving maintenance?

@schinery
Copy link

There is any plan to support redis-rb 5 in a short time? I was thinking on doing a PR for this but I can see two PRs #167 and #168 but not even reviewed. Is this project receiving maintenance?

Same here. Am debating whether I need to start looking at alternatives.

@ErebusBat
Copy link

@reneklacan can you take a look at this?

@jcagarcia
Copy link

jcagarcia commented Oct 23, 2023

I've just created this project https://github.com/jcagarcia/rollout-redis for continue with the rollout gem support. It supports working with Redis 5 and new several functionalities :) feedback is totally welcome!

@Antti Antti self-assigned this Oct 30, 2023
@maxKimoby
Copy link

Bump, can you support redis 5.0 please?

@jcagarcia
Copy link

Bump, can you support redis 5.0 please?

Did you try https://github.com/jcagarcia/rollout-redis ? It already supports redis 5 :)

@reneklacan
Copy link
Member

reneklacan commented Mar 1, 2024

Closed by #170

We apologize for the time it took to update the gem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants