Feature - Persistent groups #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LitalFiverr
reviewed
Nov 14, 2017
| def include_in_group?(group, user_identifier) | ||
| group = group.to_s | ||
| user_identifier = user_identifier.to_s | ||
| refresh_persistent_groups |
There was a problem hiding this comment.
would use more of cache pattern. move groups to be a method (getter) that refreshes the groups if needed.
refresh_persistent_groups not interesting in this method.
There was a problem hiding this comment.
thanks @LitalFiverr 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We @ Fiverr often add the same users to new rollout.
Instead of adding them 1 by 1, we wanna create a persistent groups that holds all the user identifiers.
This way we can manage easily these groups from rollout dashboard.
what do you think ? @reneklacan
** unit tests should be added before any merge
thanks!