-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isInvalidDate still allow for selecting a range on either side of the invalid date. #46
Comments
Hello, I tried to understand but I couldnt. Could you give more details on this? |
Sure, so say you have January 20 and 21 disabled, you can still select the range 18th Jan to 23rd Jan . |
Thanks, |
I think there should be two options.
The first is that it returns a list of dates within the range, excluding
the invalid dates.
The second is that it's an invalid selection.
…On Fri, 19 Oct 2018, 6:00 PM Fetrarijaona R., ***@***.***> wrote:
Thanks,
What would be the right behaviour when this happened in your opinion?
A result with an array of all available date? or the first available date?
or just not return a result?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWmMbTy4nqJP4ZM05ylaTj48vPzKiIgks5umXilgaJpZM4WooB2>
.
|
@dwjohnston if there are InvalidDates from isInvalidDate function, range (with a date invalid) becomes the first range until the first invalid date. For our example (say you have January 20 and 21 disabled, you can still select the range 18th Jan to 23rd Jan .), the range become: 18th Jan to 19 Jan (since 20 is the first disabled) Does this statement solve this issue? |
14488fb this is the commit. |
v1.2.5 is up for it. |
About this issue, if i select a range of dates and there are some disabled in said range, the result should be the full range in any case with the disabled dates showed in the calendar. Can you fix it please? |
This is perhaps a tricky issue as, perhaps you want to allow people to do that (ie. blocking out weekends, but allowing people to still select that range).
In which case - the user could apply their own 'unselect the range' function with
datesUpdated
- but for the inline picker this means you need to be able to set the set the start date and end date as inputs.The text was updated successfully, but these errors were encountered: