.btn / .buttons / .clear classes may pollute other libraries.. #62

daniel-fuelx · 2018-12-03T08:13:52Z

ngx-daterangepicker-material/src/daterangepicker/daterangepicker.component.scss

Line 633 in 2e649c6

.btn {

related to #60
After exposed CSS to global, these .btn / .buttons / .clear classes may pollute other libraries.
How about moving all these css under .md-drppicker ?

What's your plan ?
Or using ShadowDom instead of None ?
thx.

fetrarij · 2018-12-03T08:54:00Z

Hi, thanks for the report @daniel-fuelx .
What's the best suits for this? personally I thought about changing classes...

daniel-fuelx · 2018-12-04T10:28:08Z

move all these .btn / .clear / .buttons / [hidden] under .md-drppicker { } ?

@daniel-fuelx

…rppicker Close #62 thanks to @daniel-fuelx

fetrarij added the to do will work on this this when have time label Dec 12, 2018

fetrarij added a commit that referenced this issue Dec 14, 2018

style(move-css): move .btn / .clear / .buttons / [hidden] under .md-d…

8ef6b45

…rppicker Close #62 thanks to @daniel-fuelx

fetrarij mentioned this issue Dec 14, 2018

Development #74

Merged

fetrarij closed this as completed in 76406c0 Dec 14, 2018

fetrarij mentioned this issue Feb 4, 2019

How to change color? #97

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.btn / .buttons / .clear classes may pollute other libraries.. #62

.btn / .buttons / .clear classes may pollute other libraries.. #62

daniel-fuelx commented Dec 3, 2018 •

edited

fetrarij commented Dec 3, 2018

daniel-fuelx commented Dec 4, 2018

.btn / .buttons / .clear classes may pollute other libraries.. #62

.btn / .buttons / .clear classes may pollute other libraries.. #62

Comments

daniel-fuelx commented Dec 3, 2018 • edited

fetrarij commented Dec 3, 2018

daniel-fuelx commented Dec 4, 2018

daniel-fuelx commented Dec 3, 2018 •

edited