Skip to content

Commit

Permalink
feat(ui): display album years in artist and album details
Browse files Browse the repository at this point in the history
  • Loading branch information
feugy committed Oct 3, 2020
1 parent cadcf70 commit 0d94f39
Show file tree
Hide file tree
Showing 10 changed files with 35 additions and 636 deletions.
6 changes: 4 additions & 2 deletions README.md
Expand Up @@ -13,8 +13,6 @@ There are thunsands of them in the wild. This mine is an excuse for learning [El
### features

- [ ] feedback when adding to playlist
- [ ] number of disk on album details page
- [ ] display years (artist & album details page)
- [ ] images from tags
- [ ] system integration (play folder/file)
- [ ] display album/artist descriptions
Expand Down Expand Up @@ -71,6 +69,10 @@ There are thunsands of them in the wild. This mine is an excuse for learning [El
```
1. `Media service › triggerAlbumsEnrichment › retries album with no cover but at least one restriced provided`
Is a 1ms difference in expected `processedEpoch`
1. `TracksQueue component › given a list of tracks › clears tracks queue`
The list items are still visible after clear (probably because of the animation)
1. `AddToPlaylist component › given some playlists › saves new playlist with all tracks`
The dropdown menu is still visible (probably because of the animation)
## Configuring logs
Expand Down
1 change: 1 addition & 0 deletions locale/en.yml
Expand Up @@ -80,6 +80,7 @@ total duration _: 'Duration: {total}'
track details: Track details
track: Track
unknown: Unknown
using material design icons: Using <a class="underlined" href="https://material.io/resources/icons">Material Design Icons <i class="material-icons">launch</i></a>.
watched folders: Music folders
year _: 'Year: {year}'
yes: Yes
Expand Down
9 changes: 5 additions & 4 deletions locale/fr.yml
@@ -1,10 +1,10 @@
_ artists: '{total} artistes'
_ hours: '{value} heures'
_ tracks: '{total} pistes'
_ tracks: '{total} morceaux'
'#':
'artist: _': 'Artiste : {value}'
'title: _': 'Titre : {value}'
a track: 1 piste
a track: 1 morceau
about: A propos
add folders: Ajouter des dossiers
add to playlist: Ajouter à la playlist
Expand Down Expand Up @@ -63,8 +63,9 @@ show less: Voir moins
start loading some tracks: Commencez par charger quelques morceaux
total duration _: 'Durée : {total}'
track details: Détails du morceau
track: Piste
track: Morceau
unknown: Inconnu
using material design icons: Avec les icônes <a class="underlined" href="https://material.io/resources/icons">Material Design <i class="material-icons">launch</i></a>.
watched folders: Répertoires de musique
year _: 'Année : {year}'
yes: Oui
Expand All @@ -88,7 +89,7 @@ tags:
remixer: Remixeur
subtitle: Sous titre
title: Titre
track: Piste
track: Morceau
website: Site web
writer: Auteur
year: Année
Expand Down
1 change: 1 addition & 0 deletions renderer/components/Album/Album.svelte
Expand Up @@ -75,5 +75,6 @@
})}
</h4>
{/if}
<slot />
</header>
</a>
Expand Up @@ -81,6 +81,7 @@ exports[`Storyshots Components/Album Default 1`] = `
The Innocent Criminals
</a>
</h4>

</header>
</a>
</div>
Expand Down Expand Up @@ -184,6 +185,7 @@ exports[`Storyshots Components/Album Many Artists 1`] = `
Avenged Sevenfold
</a>
</h4>

</header>
</a>
</div>
Expand Down Expand Up @@ -251,6 +253,7 @@ exports[`Storyshots Components/Album No Artist 1`] = `
Diamonds on the inside
</h3>


</header>
</a>
</div>
Expand Down Expand Up @@ -338,6 +341,7 @@ exports[`Storyshots Components/Album Unknown 1`] = `
The Innocent Criminals
</a>
</h4>

</header>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/TrackDropdown/AddToPlaylist.svelte
Expand Up @@ -33,7 +33,7 @@
<div on:click={() => (open = true)}>
<i
class="material-icons">library_add</i><span>{$_('add to playlist')}</span><i
class="material-icons">arrow_drop_down</i>
class="material-icons">arrow_right</i>
</div>
<span class="button">
<AddToPlaylist
Expand Down

0 comments on commit 0d94f39

Please sign in to comment.