Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rsnowboy compile by itself #1

Merged
merged 1 commit into from Dec 3, 2019
Merged

Conversation

sheosi
Copy link
Contributor

@sheosi sheosi commented Dec 2, 2019

Include snowboy C++ library and generate snowboywrapper.
Now that I think about it maybe we should say something about the original snowboy libraries pertaining to Kitt-AI and are under Apache License

Include in repo all snowboy.a and link the corresponding one
@fewensa
Copy link
Owner

fewensa commented Dec 3, 2019

The earliest I planned to compile itself. But I have considered some issues, such as create a package and publish to crates.io, So rsnowboy not have any original snowboy libraries. And now thanks for your pr. I will check it and try solution this issues.

@fewensa fewensa merged commit 36a9c5f into fewensa:master Dec 3, 2019
@fewensa
Copy link
Owner

fewensa commented Dec 3, 2019

In Addition, About of license, I will add Apache License. Thanks.

@fewensa
Copy link
Owner

fewensa commented Dec 3, 2019

I have a bad message for you, because crates.io has a limitation,

crates.io currently has a 10MB size limit on the .crate file.

The package length is 11MB

And I try, give me an error: error: api errors (status 200 OK): max upload size is: 10485760

May not be uploaded to crates.io until restrictions are removed (If include snowboy binaries file).

@sheosi
Copy link
Contributor Author

sheosi commented May 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants