implement queries on joins and fix nested joins #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesne
approved these changes
Feb 4, 2019
kesne
reviewed
Feb 4, 2019
| @@ -36,7 +36,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "pg": "^7.7.1", | |||
| "squel": "^5.12.2" | |||
| "squel": "^5.12.2", | |||
| "@fewer/sq": "^0.1.0" | |||
There was a problem hiding this comment.
is this a required dep or just a dev dep?
kesne
reviewed
Feb 4, 2019
| export type SelectJoin = { | ||
| keys: [string, string]; | ||
| tableName: string; | ||
| select: Select; |
There was a problem hiding this comment.
I think at some point we should make the context getter flatten all of the contexts, so that you never have to call .context anywhere in the adapter.
kesne
approved these changes
Feb 4, 2019
Emily
force-pushed
the
wheres-on-nested-join
branch
from
a183edd
to
961aae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kesne see title.
Fixes #40.