Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "GasBuddy" provider #97

Merged
merged 9 commits into from
Aug 8, 2022
Merged

Conversation

christopheraryan
Copy link

@christopheraryan christopheraryan commented Aug 2, 2022

Added a new provider from GasBuddy. The prices from Autoblog are not updating as frequently as this new site. Currently this lists the least expensive gas prices but eventually I would like to modify it to also accept a list of stations so that it shows prices for just them.

Here is a sample config section:

 {
            module: "MMM-Fuel",
            position: "top_right",
            config: {
                types: ["regular"],
                provider: "gasbuddy",
                zip: "44060",
                rotate: false,
                max: 10,
                showDistance: false,
                sortBy: "regular",
            }
        },

@fewieden
Copy link
Owner

fewieden commented Aug 6, 2022

@christopheraryan thank you for your contribution. Please let me know if you need any help with my comments

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
apis/gasbuddy.js Outdated Show resolved Hide resolved
apis/gasbuddy.js Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@fewieden
Copy link
Owner

fewieden commented Aug 6, 2022

There are some merge conflicts

apis/gasbuddy.js Outdated Show resolved Hide resolved
apis/gasbuddy.js Outdated Show resolved Hide resolved
@acer123acer123
Copy link
Contributor

I think I addressed all of your comments. Thank you for the feedback!
-Chris

@fewieden
Copy link
Owner

fewieden commented Aug 8, 2022

@acer123acer123 I fixed the remaining issues, thanks again

@fewieden fewieden merged commit 3ffb5e4 into fewieden:develop Aug 8, 2022
@fewieden fewieden mentioned this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants