Remove explicit ranch dependency #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We originally added this to help address issues with older Elixir / OTP versions, but we ended up dropping support for those so hopefully removing this will fix the conflicts with the latest `cowboy` version (2.9.0).
tgautier
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a version conflict on
ranchthat comes up with the latest version ofcowboy, introduced in #205 (on my suggestion, sorry!).We originally added this to help address issues with older Elixir / OTP
versions, but we ended up dropping support for those so. I have run CI on my own fork and this change does seem to fix the issue, I also tested pulling my fork into a project that currently uses cowboy 2.9.0 and now get no issues!