Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the hostname (FQDN) configurable #74

Merged
merged 1 commit into from Oct 9, 2017

Conversation

webdeb
Copy link
Contributor

@webdeb webdeb commented Oct 8, 2017

https://github.com/Vagabond/gen_smtp#option (hostname)

hostname the hostname to be used by the smtp relay, Defaults to: smtp_util:guess_FQDN(). The hostname on your computer might not be correct, so set this to a valid value.

A bad FQDN could make your emails be filtered out as spam.

@tgautier
Copy link
Contributor

tgautier commented Oct 9, 2017

Hey, thanks for the PR, nice catch 😉

Could you please just add some tests for the configuration option you've just added?

You can have a look at smtp_adapter_test.exs for inspiration.

@webdeb
Copy link
Contributor Author

webdeb commented Oct 9, 2017

Thank you @tgautier, I added the hostname option to the main config attribute and an assertion inside the assert_configuration function, I think this should be fairly enough =)

Copy link
Contributor

@tgautier tgautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

Waiting for @kdisneur 👍 then it's a go.

@kdisneur
Copy link
Contributor

kdisneur commented Oct 9, 2017

Thanks for the PR @webdeb! :)

Could you squash your commits before we merge?

Add hostname option to README

Add test, to verify, that the hostname was properly set in gen_smpt_config

Some exlaination for the hostname option
@webdeb
Copy link
Contributor Author

webdeb commented Oct 9, 2017

sqshd® :)

@xvw xvw merged commit 57ae1e9 into fewlinesco:develop Oct 9, 2017
@webdeb webdeb deleted the bk-add-hostname-option branch October 11, 2017 16:17
@webdeb
Copy link
Contributor Author

webdeb commented Oct 11, 2017

One last question guys, what are the plans to release 1.5? Now I am including the develop branch, which is ok, but I also had problems with testing, I actually performed the tests with elixir 1.5 by manually patching the supported elixir version in mix.exs

@hisapy
Copy link

hisapy commented Apr 4, 2018

Hi guys,

Is there an estimated release date for this changes ?

Thanks in advance

@tgautier
Copy link
Contributor

tgautier commented Apr 4, 2018

Done, sorry for the delay 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants