New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the hostname (FQDN) configurable #74
Conversation
Hey, thanks for the PR, nice catch 😉 Could you please just add some tests for the configuration option you've just added? You can have a look at smtp_adapter_test.exs for inspiration. |
6605b45
to
6596c02
Compare
Thank you @tgautier, I added the hostname option to the main config attribute and an assertion inside the |
6596c02
to
f3b40ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me.
Waiting for @kdisneur 👍 then it's a go.
Thanks for the PR @webdeb! :) Could you squash your commits before we merge? |
Add hostname option to README Add test, to verify, that the hostname was properly set in gen_smpt_config Some exlaination for the hostname option
3589332
to
a0a2650
Compare
sqshd® :) |
One last question guys, what are the plans to release |
Hi guys, Is there an estimated release date for this changes ? Thanks in advance |
Done, sorry for the delay 😉 |
https://github.com/Vagabond/gen_smtp#option (hostname)
A bad FQDN could make your emails be filtered out as spam.