Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security section routing + set first password #65

Merged
merged 25 commits into from Oct 23, 2020
Merged

Security section routing + set first password #65

merged 25 commits into from Oct 23, 2020

Conversation

Fuzznimp
Copy link
Contributor

@Fuzznimp Fuzznimp commented Oct 14, 2020 •
edited

Description

This PR aims at adding the second section to Account: Security.

Context

The security seconds will have three functions:

  • Set the user password if none have been set.
  • Update the password.
  • See the last (12) connections.

What was done in this PR:

  • Create the security section flow path.
  • Create the update password form.
  • Handle password restriction and display them.
  • Updated AccountPage (i.e. sections page) integration tests.
  • Refacto Section list.
  • e2e tests to check if restriction errors are handled and displayed.
  • Some clean-up along the way.

Type of change

  • Chore (non-breaking change which refactors / improves the existing code base).
  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Issues

No issues so far.

How Has This Been Tested?

With integration tests.

Screenshots

Checklist:

  • My code follows the style contributing guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

@vercel
Copy link

vercel bot commented Oct 14, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

connect-account – ./

🔍 Inspect: https://vercel.com/fewlines/connect-account/qemhun2aj
✅ Preview: https://connect-account-git-cu-64kz08-securityroutingsetpassword.fewlines.vercel.app

connect-account-storybook – ./

🔍 Inspect: https://vercel.com/fewlines/connect-account-storybook/ijv07h3g5
✅ Preview: https://connect-account-storyb-git-cu-64kz08-securityroutingsetp-4fd047.fewlines.vercel.app

@Fuzznimp Fuzznimp force-pushed the CU-64kz08-security_routing_set_password branch from 6cff47b to 735ad8f Compare October 16, 2020 10:17
@Fuzznimp Fuzznimp force-pushed the CU-64kz08-security_routing_set_password branch from 735ad8f to 0f9ec69 Compare October 16, 2020 10:52
@Fuzznimp Fuzznimp force-pushed the CU-64kz08-security_routing_set_password branch from 0f9ec69 to 4db9c54 Compare October 16, 2020 10:57
@vercel vercel bot temporarily deployed to Preview – connect-account-storybook October 16, 2020 11:14 Inactive
@Fuzznimp Fuzznimp force-pushed the CU-64kz08-security_routing_set_password branch from ebc481e to 51e1687 Compare October 16, 2020 13:22
@vercel vercel bot temporarily deployed to Preview – connect-account-storybook October 21, 2020 16:39 Inactive
alli5723
alli5723 previously approved these changes Oct 22, 2020
View reviewed changes
Fenntasy
Fenntasy reviewed Oct 22, 2020
View reviewed changes
src/components/display/fewlines/Security/Security.tsx Outdated
export const Security: React.FC<SecurityProps> = ({ isPasswordSet }) => {
return (
<ShadowBox>
<Link href={`/account/security/${isPasswordSet ? "update" : "set"}`}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need two URLs?
Is the answer, we did but we don't anymore? 😇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daaaamn nice catch. I chose to default it as update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbb0af5

@Fuzznimp Fuzznimp merged commit cad3849 into master Oct 23, 2020
@Fuzznimp Fuzznimp deleted the CU-64kz08-security_routing_set_password branch October 23, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fenntasy Fenntasy Fenntasy approved these changes

@alli5723 alli5723 alli5723 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fuzznimp @Fenntasy @alli5723