Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot switch off auditing #56

Closed
aclemons opened this issue Sep 1, 2015 · 2 comments
Closed

Cannot switch off auditing #56

aclemons opened this issue Sep 1, 2015 · 2 comments

Comments

@aclemons
Copy link
Contributor

aclemons commented Sep 1, 2015

I could like to completely disable the auditing in ff4j in certain scenarios. Unfortunately EventPublisher is not an interface, so I cannot implement a NoOpEventPublish, but with the new setter for EventPublisher, I could set the EventPublisher to something like:

        new EventPublisher() {
            @Override
            public void publish(final Event e) {
                // do nothing
            }
        };

It would be nice if org.ff4j.FF4j had a setAuditEnabled(boolean) or something similiar which would cause it to not call getEventPublisher().publish(..) in the first place.

What do you think?

@clun
Copy link
Collaborator

clun commented Sep 2, 2015

I agree the auditEnabled flag is really good idea...

@clun
Copy link
Collaborator

clun commented Oct 29, 2015

every invocation of the publish is now embedded with the isEnableAudit() test

@clun clun closed this as completed Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants