You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the constructor for FeatureCacheProviderRedis accepts 2 parameters but uses defaults while creating new Jedis object.
public FeatureCacheProviderRedis(String host, int port) {
jedis = new Jedis(redisHost, redisport);
}
Kindly update the constructor to use the parameters.
The method below uses a prefix to search for cache keys.
@Override
public Set<String> listCachedFeatureNames() {
return jedis.keys(PREFIX_KEY + "*");
}
I believe the presence of the prefix "PREFIX_KEY" may be an error. The "put" method does not use the prefix to cache the feature. Hence this method returns empty set unless it is backed by a Redis feature store (which is not correct, as in that case it return the actual feature rather than the cached feature)
The text was updated successfully, but these errors were encountered:
bhanushe
changed the title
Fix FeatureCacheProviderRedis contructor
Fix FeatureCacheProviderRedis
Nov 19, 2015
I committed a "new" jcache store which lead to a bit of changes in all caches. (Unfortunately Redis is not yet compliant with JCache). Anyway I kept the prefix everywhere to be able to distinct features and properties.
Currently, the constructor for FeatureCacheProviderRedis accepts 2 parameters but uses defaults while creating new Jedis object.
Kindly update the constructor to use the parameters.
The method below uses a prefix to search for cache keys.
I believe the presence of the prefix "PREFIX_KEY" may be an error. The "put" method does not use the prefix to cache the feature. Hence this method returns empty set unless it is backed by a Redis feature store (which is not correct, as in that case it return the actual feature rather than the cached feature)
The text was updated successfully, but these errors were encountered: