Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pole-zero: pull request branch for supporting pole-zero plots #94

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

josmithiii
Copy link

This pull request adds open circles (o) and crosses (x) to XYDragComponent. See screenshot for an example of how it can look.
image

@josmithiii josmithiii changed the title pole-zero: branch pole-zero started for pull request on supporting pole-zero plots pole-zero: pull request branch for supporting pole-zero plots Aug 3, 2023
@ffAudio
Copy link
Owner

ffAudio commented Feb 19, 2024

Hi Julius,
Sorry for letting this lying around. I think it would be a great addition.
IIRC it was the same issue about the not being unavailable on windows, is that possible?
If you update that so it succeeds on windows too, I am happy to merge it.
Cheers!

@josmithiii
Copy link
Author

Hi Daniel,

Thanks for circling back - no hurries. Unfortunately the logs are expired. It appears I need to force the checks to run again. I'll see if I can figure out what to do . . .

@josmithiii
Copy link
Author

I tried re-synching my fork and refreshing the PR - awaiting actions I presume

@ffAudio
Copy link
Owner

ffAudio commented Feb 19, 2024

Ok, it is building now.
Although I was thinking about it:

  • first idea was to create a LookAndFeel method for the XY-dragger
    This way you could create a bespoke draw function yourself.
    The drawback would be, it could be crowded with LookAndFeels.

  • second idea: create a LookAndFeel but allow a fixed number like 8 different shapes you can select like you did...
    Are those poles just for displaying or are they interactive?

@ffAudio
Copy link
Owner

ffAudio commented Feb 19, 2024 via email

@josmithiii
Copy link
Author

josmithiii commented Feb 20, 2024

Super happy to hear you are working on PGM again! I checked out my PR, changed 'not' to '!', and it builds and tests ok for me. How do I trigger a Windows recompile attempt, or is that automatic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants