Changes for better IEEE 1901-2010 compliance in sniffer mode #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structures added for decoding frames according to delimiter type, and also for decoding beacon MPDU payload.
Functions added for decoding frames according to delimiter type, and also for decoding beacon MPDU payload. Various changes made to better describe fields and give values in both decimal and hex (and occasionally binary).
Only change is to initial message (so that it's possible to tell that the forked version of faifa is being run).
|
Also, could you make sure that you update Wireshark's dissector for HomePlugAV for these IEEE amendments? The dissector in Wireshark is a much better tool than faifa when it comes to displaying and parsing management frames. Thanks! |
|
I agree Wireshark is a better tool, but it lacks the facility for putting a QCA based Homeplug adapter into sniffer mode. If you can please point me at the Wireshark code, I'll take a look. |
|
The wireshark dissector is here: |
ghost
pushed a commit
to wireshark/wireshark
that referenced
this pull request
Dec 15, 2016
This patch modifies the homeplug-av dissector to better decode sniffer data according to the IEEE 1901-2010 standard. The dissector now decodes MPDU variant fields correctly based on delimiter type, and decodes beacon MPDU payloads. There are some variable-length fields it doesn't handle yet. This patch should have no effect on how non-sniffer-data packets are decoded. These changes are based on Andrew Margolis' pull request to faifa at ffainelli/faifa#11 Change-Id: Ia60ac7affa99a68b38f04ab66373ac715c761328 Reviewed-on: https://code.wireshark.org/review/19156 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
gbloice
pushed a commit
to gbloice/wireshark
that referenced
this pull request
Dec 15, 2016
This patch modifies the homeplug-av dissector to better decode sniffer data according to the IEEE 1901-2010 standard. The dissector now decodes MPDU variant fields correctly based on delimiter type, and decodes beacon MPDU payloads. There are some variable-length fields it doesn't handle yet. This patch should have no effect on how non-sniffer-data packets are decoded. These changes are based on Andrew Margolis' pull request to faifa at ffainelli/faifa#11 Change-Id: Ia60ac7affa99a68b38f04ab66373ac715c761328 Reviewed-on: https://code.wireshark.org/review/19156 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
Wireshark is a much better tool for such dissection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork has been made in order to better decode HP-AV frames in sniffer mode according to the IEEE 1901-2010 standard.
Specifically, the modules homeplug_av.h and frame.c have had structures and functions added for decoding frames differentially according to delimiter type, and also for decoding beacon MPDU payload. Various changes made to better describe fields and give values in both decimal and hex (and occasionally binary).
Tested using Debian GNU/Linux 8 with a variety of Homeplug adapters having both QCA and Broadcmm chipsets. (Obviously, the Broadcom chipsets don't implement the Intellon/QCA proprietary sniffer mode, but the frames they emit can be successfully sniffed once an Intellon/QCA adapter is added to a Broadcmm Homeplug network).