PR feedback

ffaker · Sep 19, 2023 · 8f5b771 · 8f5b771
1 parent 485046f
commit 8f5b771
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/ffaker/bank_us.rb b/lib/ffaker/bank_us.rb
@@ -5,12 +5,14 @@ module BankUS
     extend ModuleUtils
     extend self
 
+    ROUTING_NUMBER_PREFIXES = [*'00'..'12', *'21'..'32', *'61'..'72', '80']
+
     def account_number(min_digits: 9, max_digits: 17)
       FFaker.numerify('#' * rand(min_digits..max_digits))
     end
 
     def routing_number
-      first_two_digits = fetch_sample([*'00'..'12', *'21'..'32', *'61'..'72', '80'])
+      first_two_digits = fetch_sample(ROUTING_NUMBER_PREFIXES)
 
       partial_routing_number = FFaker.numerify("#{first_two_digits}######")
       ninth_digit = generate_ninth_digit(partial_routing_number)

diff --git a/test/test_bank_us.rb b/test/test_bank_us.rb
@@ -24,8 +24,7 @@ def test_routing_number
     routing_number = @tester.routing_number
     assert_match(/\A\d{9}\z/, routing_number)
 
-    first_two_digit_range = ((0..12).to_a + (21..32).to_a + (61..72).to_a + [80])
-    assert_true(first_two_digit_range.include?(routing_number[0..1].to_i))
+    assert_true(@tester::ROUTING_NUMBER_PREFIXES.include?(routing_number[0..1]))
 
     checksum = (
       (7 * (routing_number[0].to_i + routing_number[3].to_i + routing_number[6].to_i)) +