Adds FFaker::Bank.routing_number and accounting_number #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
professor
force-pushed
the
ts/adds-bank-routing-number
branch
3 times, most recently
from
ad21fae
to
0b31036
Compare
AlexWayfer
reviewed
Sep 9, 2023
marocchino
reviewed
Sep 11, 2023
professor
force-pushed
the
ts/adds-bank-routing-number
branch
from
0b31036
to
8ea8bc1
Compare
Done. |
professor
force-pushed
the
ts/adds-bank-routing-number
branch
2 times, most recently
from
7345443
to
42297dd
Compare
marocchino
reviewed
Sep 18, 2023
professor
force-pushed
the
ts/adds-bank-routing-number
branch
2 times, most recently
from
b8d1ac1
to
3ce0fd1
Compare
professor
force-pushed
the
ts/adds-bank-routing-number
branch
from
3ce0fd1
to
cebd12c
Compare
professor
force-pushed
the
ts/adds-bank-routing-number
branch
from
cebd12c
to
c6730be
Compare
|
@marocchino thank you for the approval. This PR has been in a green state for a little over 7 days with no new comments. I would love to see it merged this week. |
|
You've waited too long. I think this will be okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
FFaker::Bank.routing_number and accounting_numberFor our use case, we're looking for realistic looking US Bank account numbers and routing numbers.
Accounting numbers can very between 9 and 17 digits (Reference) Routing numbers have a checksum calculation on the last digit.