Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #62

Merged
merged 12 commits into from
Apr 19, 2017
Merged

Dev #62

merged 12 commits into from
Apr 19, 2017

Conversation

xiaoshude
Copy link
Collaborator

add new steps

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.7%) to 80.766% when pulling bf3e9ec on dev into 45fd557 on master.

Copy link
Contributor

@php-cpm php-cpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好消息,重大变更

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.5%) to 84.944% when pulling ecf5682 on dev into 45fd557 on master.

@@ -39,7 +39,7 @@
<div class="nav-group-title">{{'Navigation'|translate}}</div>
<ul>
<!--<li ui-sref-active="active"><a ui-sref="{{vm.globalRoute('tabs')}}">{{'tabs'|translate}}</a></li>-->
<!--<li ui-sref-active="active"><a ui-sref="{{vm.globalRoute('steps')}}">{{'steps'|translate}}</a></li>-->
<li ui-sref-active="active"><a ui-sref="{{vm.globalRoute('steps')}}">{{'steps'|translate}}</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前管总说不要steps组件了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重写了,之前的有点问题

@@ -16,8 +16,8 @@ class ElementFinder {
this.element = angular.element(element)[0];
}

controller() {
return angular.element(this.element).scope().$$childHead;
controllerInstance() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个区别是啥?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是controller实例

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 85.82% when pulling 40c0264 on dev into 45fd557 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.4%) to 86.027% when pulling c623aad on dev into 45fd557 on master.

@bcguan2008 bcguan2008 merged commit 89e3625 into master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants