Add webdriver-based fetcher to avoid Error 403 and some other small improvements #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use unittest from standart lib as main lib for testing Move .py file with fixtures to subdir to avoid relative import (tests) Update requierements: use newer versions of numpy and pandas Fix bug with depreciated module collections.Container
Use new fetcher for meta data downloading Sort imports in export.py module Update requirements.txt
Bump the version to 5.1.2 Improve caching of the meta data fetcher Add Dockerfile for isolated testing Suppress webdriver log messages Update setup.py and requirements.txt Update readme and changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request restores functioning of the library.
In December 2022, the data provider added token protection to their website. Therefore, it is impossible to use the default GET request to receive meta data. To fix this, I made the following changes:
I tested the updated version of the library with Python 3.7 to 3.11, and everything works well.
As modern versions of Numpy and Pandas do not support Python 3.7, I added additional code to the setup.py file to avoid dropping support for Python 3.7. Also I updated changelog and readme file.