Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add OG data #67

Merged
merged 3 commits into from
Feb 19, 2019
Merged

chore: Add OG data #67

merged 3 commits into from
Feb 19, 2019

Conversation

ffflorian
Copy link
Owner

No description provided.

@ffflorian ffflorian mentioned this pull request Feb 19, 2019
Open
lipis
lipis reviewed Feb 19, 2019
View reviewed changes
public/index.html Outdated Show resolved Hide resolved
@lipis @ffflorian
Update public/index.html
2ab79da 
Co-Authored-By: ffflorian <ffflorian@users.noreply.github.com>
lipis
lipis suggested changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@lipis lipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix some warnings https://developers.facebook.com/tools/debug/sharing/?q=https%3A%2F%2Fsortjson.com

lipis
lipis suggested changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@lipis lipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also pass this one: https://cards-dev.twitter.com/validator

@ffflorian
Copy link
Owner Author

Fix some warnings https://developers.facebook.com/tools/debug/sharing/?q=https%3A%2F%2Fsortjson.com

screenshot from 2019-02-19 13-43-24

Nope 😃

@lipis lipis mentioned this pull request Feb 19, 2019
Open
@ffflorian
Copy link
Owner Author

Should also pass this one: https://cards-dev.twitter.com/validator

screenshot from 2019-02-19 13-43-57

Also nope

@lipis
Copy link
Contributor

lipis commented Feb 19, 2019

Well, even if you don't agree with some of their policies, being able to share this tool on these platforms is beneficial. Besides the fact that as web developers we should be able to test these pages. For the same reasons we try to deliver the same experience on all OS platforms and as many browsers as possible even if we are not Safari or MS Edge users :)

@ffflorian
Copy link
Owner Author

ffflorian commented Feb 19, 2019 •
edited
Loading

Well, even if you don't agree with some of their policies, being able to share this tool on these platforms is beneficial. Besides the fact that as web developers we should be able to test these pages. For the same reasons we try to deliver the same experience on all OS platforms and as many browsers as possible even if we are not Safari or MS Edge users :)

That's true, but I don't want to create an account only for using their validators 🙂

I'll use https://search.google.com/structured-data/testing-tool for now

@lipis
Copy link
Contributor

lipis commented Feb 19, 2019

For the same reasons that we have different devices for testing (Macbook, PC, Tablets, Phones) I think it makes sense to have testing accounts in these platforms.

@ffflorian
Copy link
Owner Author

For the same reasons that we have different devices for testing (Macbook, PC, Tablets, Phones) I think it makes sense to have testing accounts in these platforms.

Good idea!

@lipis
Copy link
Contributor

lipis commented Feb 19, 2019

https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fsortjson.com 85/100

@ffflorian ffflorian merged commit 0ef980a into master Feb 19, 2019
@ffflorian ffflorian deleted the chore/open-graph branch February 19, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipis lipis lipis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ffflorian @lipis