Not returning ERR correctly in update_cert_handler

[cdloh]

Whilst working on #20 I noted that errors aren't being returned in update_cert_handler

lua-resty-acme/lib/resty/acme/autossl.lua

Lines 173 to 190 in 35fbb9c

	if err then
	log(ngx_ERR, "error updating cert for ", domain, " err: ", err)
	return
	end
	local serialized = json.encode({
	domain = domain,
	pkey = pkey,
	cert = cert,
	type = typ,
	updated = ngx.now(),
	})
	local err = AUTOSSL.storage:set(domain_cache_key, serialized)
	if err then
	log(ngx_ERR, "error storing cert and key to storage ", err)
	return
	end

The code is relying on that error for further down

lua-resty-acme/lib/resty/acme/autossl.lua

Lines 223 to 228 in 35fbb9c

	err = update_cert_handler(data)
	-- yes we don't release lock, but wait it to expire after negative cache is cleared
	return err
	end

Unless I'm missing something?

[fffonion]

I think you are right, let me fix it tomorrow. Thanks for reporting this! Callum Loh <notifications@github.com>于2021年1月13日 周三上午12:22写道：

Whilst working on #20 <#20> I noted that errors aren't being returned in update_cert_handler https://github.com/fffonion/lua-resty-acme/blob/35fbb9c46a9deb39a250da1fbaf5eb0cedd3ccd4/lib/resty/acme/autossl.lua#L173-L190 The code is relying on that error for further down https://github.com/fffonion/lua-resty-acme/blob/35fbb9c46a9deb39a250da1fbaf5eb0cedd3ccd4/lib/resty/acme/autossl.lua#L224 Unless I'm missing something? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQJLFLYIMDVO4ZPGBWBMPDSZRZNHANCNFSM4V7OOS2Q> .

-- Regards fffonion (B607 2745 84E8 D5E5 <https://yooooo.us/gpg.txt>)

[cdloh]

I've submitted an MR but feel free not to use incase you want to change the logging around as well.