Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ブックマークが消える #82

Closed
sayurin opened this issue Mar 9, 2019 · 0 comments
Closed

ブックマークが消える #82

sayurin opened this issue Mar 9, 2019 · 0 comments
Labels
bug
Milestone
v3.7

Comments

@sayurin
Copy link
Member

sayurin commented Mar 9, 2019 •
edited
Loading

ffftp/bookmark.cpp

Line 100 in 16154e7

SetHostBookMark(CurHost, u8(total).data(), size_as<int>(total));

ブックマークパスに日本語文字が含まれていると、ここで指定している文字列長がずれるためブックマークが不正になり正しく保存できない。

こちらで指摘いただいた。
https://twitter.com/mn_imd/status/1103826286361763840
@sayurin sayurin added the bug label Mar 9, 2019
@sayurin sayurin added this to the v3.7 milestone Mar 9, 2019
@sayurin sayurin mentioned this issue Mar 10, 2019
Merged
hwtnb pushed a commit to HaijinW/ffftp that referenced this issue Oct 31, 2022
@sayurin
fixed ffftp#82, bookmark with multibyte chars.
b99cc6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
1 participant
@sayurin