Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with BigInt and tsconfig #10

Closed
wants to merge 4 commits into from
Closed

Fix issues with BigInt and tsconfig #10

wants to merge 4 commits into from

Conversation

TimothyJones
Copy link
Contributor

Apologies, my last PR introduced two more problems:

  1. Node 12 does include some es2020 features (example tsconfig)
  2. For some reason, TypeScript doesn't accept BigInt literals when targeting node 12

I checked that this one actually passes (I can't run the tests locally because of some arm64 issue that I haven't looked into yet).

@TimothyJones TimothyJones changed the title Actually fix build Fix issues with BigInt and tsconfig Oct 13, 2021
@TimothyJones
Copy link
Contributor Author

Just realised the last one was squash merged, so I gave the PR a better title.

@lygstate lygstate closed this Oct 14, 2021
@lygstate
Copy link
Contributor

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimothyJones @lygstate