Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the labeler config will not work in the PR that they are submitted with #7

Closed
TheCleric opened this issue Aug 17, 2020 · 2 comments · Fixed by #9
Closed

Changes to the labeler config will not work in the PR that they are submitted with #7

TheCleric opened this issue Aug 17, 2020 · 2 comments · Fixed by #9

Comments

@TheCleric
Copy link
Contributor

I ran into an issue where the labeler wasn't working for me. After adding some debugging to a fork of it, I discovered since getContents of the config file operates off the repo's default version of the config, changes to the config within the PR are ignored.
@TheCleric
Copy link
Contributor Author

I have created a PR to address this. It accesses the config file in the current head ref of the PR:

#6

@TheCleric TheCleric mentioned this issue Aug 17, 2020
Closed
@ffittschen
Copy link
Owner

Hi, yes we came to the same conclusion in the last issue: #4. Thanks for taking the time to open a PR for it!

@TheCleric TheCleric mentioned this issue Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TheCleric @ffittschen