Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enhanced debugging and the ability to use changes to the config file within the PR itself #9

Merged
merged 21 commits into from
Aug 27, 2020

Conversation

TheCleric
Copy link
Contributor

@TheCleric TheCleric commented Aug 25, 2020

This is a new PR to replace #6

That PR accidentally got changes merged into it that were not related to the PR itself.

Should resolve #7

Copy link
Owner

@ffittschen ffittschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for recreating the PR, this is a lot cleaner 🙂 The code looks already pretty good 👍🏻 I just added some small comments / suggestions

src/config.ts Outdated Show resolved Hide resolved
src/config.ts Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Show resolved Hide resolved
TheCleric and others added 4 commits August 25, 2020 15:38
Co-authored-by: Florian Fittschen <ffittschen@gmail.com>
Co-authored-by: Florian Fittschen <ffittschen@gmail.com>
Co-authored-by: Florian Fittschen <ffittschen@gmail.com>
Co-authored-by: Florian Fittschen <ffittschen@gmail.com>
@TheCleric
Copy link
Contributor Author

@ffittschen Please review again. See above comment on the one outstanding code suggestion.

@ffittschen
Copy link
Owner

@TheCleric Looks good to me 👍🏻 Thanks again for the contribution, this makes it a lot easier to integrate it into repositories that have protected branches.

Also pinging @AndrewLeedham to let him know that his issue #4 is resolved by this PR as well.

@ffittschen ffittschen merged commit b3000eb into ffittschen:master Aug 27, 2020
@ffittschen
Copy link
Owner

I'll create a new release of the action in the evening

@TheCleric TheCleric deleted the feature/enhance-debugging branch February 25, 2021 20:23
@jimmya jimmya mentioned this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to the labeler config will not work in the PR that they are submitted with
2 participants