-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added enhanced debugging and the ability to use changes to the config file within the PR itself #9
Added enhanced debugging and the ability to use changes to the config file within the PR itself #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for recreating the PR, this is a lot cleaner 🙂 The code looks already pretty good 👍🏻 I just added some small comments / suggestions
Co-authored-by: Florian Fittschen <ffittschen@gmail.com>
Co-authored-by: Florian Fittschen <ffittschen@gmail.com>
Co-authored-by: Florian Fittschen <ffittschen@gmail.com>
Co-authored-by: Florian Fittschen <ffittschen@gmail.com>
@ffittschen Please review again. See above comment on the one outstanding code suggestion. |
@TheCleric Looks good to me 👍🏻 Thanks again for the contribution, this makes it a lot easier to integrate it into repositories that have protected branches. Also pinging @AndrewLeedham to let him know that his issue #4 is resolved by this PR as well. |
I'll create a new release of the action in the evening |
This is a new PR to replace #6
That PR accidentally got changes merged into it that were not related to the PR itself.
Should resolve #7