Make offset/line/fragment private attributes. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xd34d10cc
reviewed
Feb 8, 2020
src/lib.rs
Outdated
| fragment: program, | ||
| extra: extra, | ||
| } | ||
| } | ||
|
|
||
| /// Similar to `new_extra`, but allows overriding offset and line. | ||
| /// This is unsafe, because giving an offset too large may result in UD, |
0xd34d10cc
reviewed
Feb 8, 2020
src/lib.rs
Outdated
| self.offset | ||
| } | ||
|
|
||
| /// The fragment that is spanned. |
There was a problem hiding this comment.
I guess this is doc for fragment() function, not location_line()
|
Looks good to me. |
Mutating them (or building a LocatedSpan from scratch) may result in undefined behavior if the offset is invalid.
progval
force-pushed
the
private-offset-fragment
branch
from
c6368e7
to
0d7f875
Compare
|
Good catches, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutating
offsetandfragment(or building a LocatedSpan from scratch) may resultin undefined behavior if the offset is invalid.
linedoesn't need to be private, but I'm making it anyway, just in case we ever need it.Fixes #45
@0xd34d10cc How does that look?