Fix typo #541
Fix typo #541
Conversation
✅ Deploy Preview for ffmpegwasm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
apps/vanilla-app/README.md
Outdated
| @@ -4,19 +4,19 @@ | |||
|
|
|||
| You need to download assets from npm before running the examples: | |||
|
|
|||
| ```bash | |||
| ``` | |||
There was a problem hiding this comment.
May I ask the reason removing bash here?
There was a problem hiding this comment.
Good question. the bash annotation is useful only in bash scripts, i.e. files that end in .sh etc. This command I'm removing the bash bash annotation from is a global terminal command, i.e. it could be run on Windows, Mac or Linux shell. The annotation colors sometimes some commands that have no correlation to the global terminal commands.
There was a problem hiding this comment.
Got it, but I think it is still better to keep his for basic syntax highlight. I would suggest to keep it.
There was a problem hiding this comment.
Sure thing. If my reasoning was not good enough I'll change it back as you wish.
There was a problem hiding this comment.
Just make sure to squash the commits if you're the one merging!
|
Merged, thanks for the contribution. |
No description provided.