libavutil/tests/md5: Avoid warnings #20

softworkz · 2022-01-21T00:14:25Z

Those are always showing up on Patchwork
when FATE tests are failing, covering
some possibly more useful information.

v4:

The problem still exists:
https://patchwork.ffmpeg.org/check/62130/
as was suggested, this patch removes the volatile keyword altogether

cc: James Almer jamrial@gmail.com
cc: Soft Works softworkz@hotmail.com
cc: Carl Eugen Hoyos ceffmpeg@gmail.com
cc: Marton Balint cus@passwd.hu

softworkz · 2022-01-21T00:15:54Z

/preview

ffmpeg-codebot · 2022-01-21T00:16:15Z

Preview email sent as pull.20.ffstaging.FFmpeg.1642724173577.ffmpegagent@gmail.com

softworkz · 2022-01-21T01:17:18Z

/submit

ffmpeg-codebot · 2022-01-21T01:17:54Z

Submitted as pull.20.ffstaging.FFmpeg.1642727870274.ffmpegagent@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v1

To fetch this version to local tag pr-ffstaging-20/softworkz/submit_md5-v1:

git fetch --no-tags https://github.com/ffstaging/FFmpeg tag pr-ffstaging-20/softworkz/submit_md5-v1

softworkz · 2022-01-21T01:41:05Z

/submit

ffmpeg-codebot · 2022-01-21T01:41:26Z

Submitted as pull.20.v2.ffstaging.FFmpeg.1642729284250.ffmpegagent@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v2

To fetch this version to local tag pr-ffstaging-20/softworkz/submit_md5-v2:

git fetch --no-tags https://github.com/ffstaging/FFmpeg tag pr-ffstaging-20/softworkz/submit_md5-v2

ffmpeg-codebot · 2022-01-21T01:46:47Z

On the FFmpeg mailing list, James Almer wrote (reply to this):



On 1/20/2022 10:41 PM, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> 
> Those are always showing up on Patchwork
> when FATE tests are failing, covering
> some possibly more useful information.
> 
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>      libavutil/tests/md5: Avoid warnings
>      
>      Those are always showing up on Patchwork when FATE tests are failing,
>      covering some possibly more useful information.
> 
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v2
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
> 
> Range-diff vs v1:
> 
>   1:  3910d81fa1 ! 1:  4723054463 libavutil/tests/md5: Avoid warnings
>       @@ libavutil/tests/md5.c: int main(void)
>         {
>             uint8_t md5val[16];
>             int i;
>       -+
>       -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
>       -     volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>       +-    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>        -    // FIXME remove volatile once it has been fixed and all fate clients are updated
>       -+#else
>       -+    uint8_t in[1000];
>       ++
>       ++#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
>       ++    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>        +#endif
>       ++    uint8_t in[1000];
>         
>             for (i = 0; i < 1000; i++)
>                 in[i] = i * i;
> 
> 
>   libavutil/tests/md5.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> index 42e4538e0a..cca63d6507 100644
> --- a/libavutil/tests/md5.c
> +++ b/libavutil/tests/md5.c
> @@ -33,8 +33,11 @@ int main(void)
>   {
>       uint8_t md5val[16];
>       int i;
> -    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
> -    // FIXME remove volatile once it has been fixed and all fate clients are updated
> +
> +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4

1?

> +    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
> +#endif
> +    uint8_t in[1000];
>   
>       for (i = 0; i < 1000; i++)
>           in[i] = i * i;
> 
> base-commit: 7512293cf912c65fa657eab680afd5e18fd47603
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

ffmpeg-codebot · 2022-01-21T01:46:48Z

User James Almer <jamrial@gmail.com> has been added to the cc: list.

softworkz · 2022-01-21T01:47:50Z

/submit

ffmpeg-codebot · 2022-01-21T01:48:09Z

Submitted as pull.20.v3.ffstaging.FFmpeg.1642729686725.ffmpegagent@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v3

To fetch this version to local tag pr-ffstaging-20/softworkz/submit_md5-v3:

git fetch --no-tags https://github.com/ffstaging/FFmpeg tag pr-ffstaging-20/softworkz/submit_md5-v3

ffmpeg-codebot · 2022-01-21T01:48:46Z

On the FFmpeg mailing list, Soft Works wrote (reply to this):



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James Almer
> Sent: Friday, January 21, 2022 2:45 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings
> 
> 
> 
> On 1/20/2022 10:41 PM, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > Those are always showing up on Patchwork
> > when FATE tests are failing, covering
> > some possibly more useful information.
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> >      libavutil/tests/md5: Avoid warnings
> >
> >      Those are always showing up on Patchwork when FATE tests are failing,
> >      covering some possibly more useful information.
> >
> > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2
> > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-
> 20/softworkz/submit_md5-v2
> > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
> >
> > Range-diff vs v1:
> >
> >   1:  3910d81fa1 ! 1:  4723054463 libavutil/tests/md5: Avoid warnings
> >       @@ libavutil/tests/md5.c: int main(void)
> >         {
> >             uint8_t md5val[16];
> >             int i;
> >       -+
> >       -+#if defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> >       -     volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >       +-    volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >        -    // FIXME remove volatile once it has been fixed and all fate
> clients are updated
> >       -+#else
> >       -+    uint8_t in[1000];
> >       ++
> >       ++#if 1 || defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> >       ++    volatile // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >        +#endif
> >       ++    uint8_t in[1000];
> >
> >             for (i = 0; i < 1000; i++)
> >                 in[i] = i * i;
> >
> >
> >   libavutil/tests/md5.c | 7 +++++--
> >   1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> > index 42e4538e0a..cca63d6507 100644
> > --- a/libavutil/tests/md5.c
> > +++ b/libavutil/tests/md5.c
> > @@ -33,8 +33,11 @@ int main(void)
> >   {
> >       uint8_t md5val[16];
> >       int i;
> > -    volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > -    // FIXME remove volatile once it has been fixed and all fate clients
> are updated
> > +
> > +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__
> < 4
> 
> 1?

I'm an idiot...

Thanks
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

ffmpeg-codebot · 2022-01-21T01:48:48Z

User Soft Works <softworkz@hotmail.com> has been added to the cc: list.

ffmpeg-codebot · 2022-01-22T23:29:19Z

On the FFmpeg mailing list, Carl Eugen Hoyos wrote (reply to this):

Am Fr., 21. Jan. 2022 um 02:18 Uhr schrieb softworkz <ffmpegagent@gmail.com>:
>
> From: softworkz <softworkz@hotmail.com>
>
> Those are always showing up on Patchwork
> when FATE tests are failing, covering
> some possibly more useful information.
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>     libavutil/tests/md5: Avoid warnings
>
>     Those are always showing up on Patchwork when FATE tests are failing,
>     covering some possibly more useful information.
>
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v1
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v1
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
>
>  libavutil/tests/md5.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> index 42e4538e0a..1f27c40987 100644
> --- a/libavutil/tests/md5.c
> +++ b/libavutil/tests/md5.c
> @@ -33,8 +33,12 @@ int main(void)
>  {
>      uint8_t md5val[16];
>      int i;
> +
> +#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
>      volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
> -    // FIXME remove volatile once it has been fixed and all fate clients are updated

I wonder if the volatile shouldn't just be removed after eight years.

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

ffmpeg-codebot · 2022-01-22T23:29:22Z

User Carl Eugen Hoyos <ceffmpeg@gmail.com> has been added to the cc: list.

ffmpeg-codebot · 2022-02-03T21:49:10Z

On the FFmpeg mailing list, Soft Works wrote (reply to this):



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Carl
> Eugen Hoyos
> Sent: Sunday, January 23, 2022 12:23 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] libavutil/tests/md5: Avoid
> warnings
> 
> Am Fr., 21. Jan. 2022 um 02:18 Uhr schrieb softworkz
> <ffmpegagent@gmail.com>:
> >
> > From: softworkz <softworkz@hotmail.com>
> >
> > Those are always showing up on Patchwork
> > when FATE tests are failing, covering
> > some possibly more useful information.
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> >     libavutil/tests/md5: Avoid warnings
> >
> >     Those are always showing up on Patchwork when FATE tests are
> failing,
> >     covering some possibly more useful information.
> >
> > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v1
> > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-
> ffstaging-20/softworkz/submit_md5-v1
> > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
> >
> >  libavutil/tests/md5.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> > index 42e4538e0a..1f27c40987 100644
> > --- a/libavutil/tests/md5.c
> > +++ b/libavutil/tests/md5.c
> > @@ -33,8 +33,12 @@ int main(void)
> >  {
> >      uint8_t md5val[16];
> >      int i;
> > +
> > +#if defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> >      volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > -    // FIXME remove volatile once it has been fixed and all fate
> clients are updated
> 
> I wonder if the volatile shouldn't just be removed after eight years.
> 
> Carl Eugen

So, shall I submit another version that simply removes 'volatile'?

softworkz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Those are always showing up on Patchwork when FATE tests are failing, covering some possibly more useful information. The volatile keyword was used as a workaround for an eight year old clang version. Signed-off-by: softworkz <softworkz@hotmail.com>

softworkz · 2022-05-28T15:06:42Z

/submit

ffmpeg-codebot · 2022-05-28T15:07:03Z

Submitted as pull.20.v4.ffstaging.FFmpeg.1653750420780.ffmpegagent@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v4

To fetch this version to local tag pr-ffstaging-20/softworkz/submit_md5-v4:

git fetch --no-tags https://github.com/ffstaging/FFmpeg tag pr-ffstaging-20/softworkz/submit_md5-v4

ffmpeg-codebot · 2022-06-08T20:27:46Z

On the FFmpeg mailing list, Marton Balint wrote (reply to this):



On Sat, 28 May 2022, softworkz wrote:

> From: softworkz <softworkz@hotmail.com>
>
> Those are always showing up on Patchwork when FATE tests are failing,
> covering some possibly more useful information.
>
> The volatile keyword was used as a workaround for an eight year old
> clang version.
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>    libavutil/tests/md5: Avoid warnings

Will apply.

Thanks,
Marton

>
>    Those are always showing up on Patchwork when FATE tests are failing,
>    covering some possibly more useful information.
>
>    v4:
>
>     * The problem still exists:
>       https://patchwork.ffmpeg.org/check/62130/
>     * as was suggested, this patch removes the volatile keyword altogether
>
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v4
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v4
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
>
> Range-diff vs v3:
>
> 1:  e54769c621 ! 1:  21fdf3eba2 libavutil/tests/md5: Avoid warnings
>     @@ Metadata
>      Author: softworkz <softworkz@hotmail.com>
>
>       ## Commit message ##
>     -    libavutil/tests/md5: Avoid warnings
>     +    libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings
>
>     -    Those are always showing up on Patchwork
>     -    when FATE tests are failing, covering
>     -    some possibly more useful information.
>     +    Those are always showing up on Patchwork when FATE tests are failing,
>     +    covering some possibly more useful information.
>     +
>     +    The volatile keyword was used as a workaround for an eight year old
>     +    clang version.
>
>          Signed-off-by: softworkz <softworkz@hotmail.com>
>
>     @@ libavutil/tests/md5.c: int main(void)
>      -    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>      -    // FIXME remove volatile once it has been fixed and all fate clients are updated
>      +
>     -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
>     -+    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>     -+#endif
>      +    uint8_t in[1000];
>
>           for (i = 0; i < 1000; i++)
>
>
> libavutil/tests/md5.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> index 42e4538e0a..0ac8f2834e 100644
> --- a/libavutil/tests/md5.c
> +++ b/libavutil/tests/md5.c
> @@ -33,8 +33,8 @@ int main(void)
> {
>     uint8_t md5val[16];
>     int i;
> -    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
> -    // FIXME remove volatile once it has been fixed and all fate clients are updated
> +
> +    uint8_t in[1000];
>
>     for (i = 0; i < 1000; i++)
>         in[i] = i * i;
>
> base-commit: 9fba0b8a8c754a012fc74c90ffb7c26a56be8ca0
> -- 
> ffmpeg-codebot
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

ffmpeg-codebot · 2022-06-08T20:27:48Z

User Marton Balint <cus@passwd.hu> has been added to the cc: list.

softworkz · 2022-06-09T23:38:14Z

Applied to master.

softworkz force-pushed the submit_md5 branch from 3910d81 to 4723054 Compare January 21, 2022 01:38

softworkz force-pushed the submit_md5 branch from 4723054 to e54769c Compare January 21, 2022 01:47

softworkz force-pushed the submit_md5 branch from e54769c to 21fdf3e Compare May 28, 2022 15:04

softworkz closed this Jun 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libavutil/tests/md5: Avoid warnings #20

libavutil/tests/md5: Avoid warnings #20

softworkz commented Jan 21, 2022 •

edited by ffmpeg-codebot bot

softworkz commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

softworkz commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

softworkz commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

softworkz commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 22, 2022

ffmpeg-codebot bot commented Jan 22, 2022

ffmpeg-codebot bot commented Feb 3, 2022

softworkz commented May 28, 2022

ffmpeg-codebot bot commented May 28, 2022

ffmpeg-codebot bot commented Jun 8, 2022

ffmpeg-codebot bot commented Jun 8, 2022

softworkz commented Jun 9, 2022

libavutil/tests/md5: Avoid warnings #20

libavutil/tests/md5: Avoid warnings #20

Conversation

softworkz commented Jan 21, 2022 • edited by ffmpeg-codebot bot

softworkz commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

softworkz commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

softworkz commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

softworkz commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 21, 2022

ffmpeg-codebot bot commented Jan 22, 2022

ffmpeg-codebot bot commented Jan 22, 2022

ffmpeg-codebot bot commented Feb 3, 2022

softworkz commented May 28, 2022

ffmpeg-codebot bot commented May 28, 2022

ffmpeg-codebot bot commented Jun 8, 2022

ffmpeg-codebot bot commented Jun 8, 2022

softworkz commented Jun 9, 2022

softworkz commented Jan 21, 2022 •

edited by ffmpeg-codebot bot