Support long file names on Windows #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/submit |
|
Submitted as pull.28.ffstaging.FFmpeg.1652435595.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
On the FFmpeg mailing list, Soft Works wrote (reply to this): |
|
User |
![ffmpeg-codebot[bot]](https://avatars.githubusercontent.com/in/158557?s=60&v=4){kind=small}
|
On the FFmpeg mailing list, nil-admirari@mailo.com wrote (reply to this): |
|
On the FFmpeg mailing list, Soft Works wrote (reply to this): |
softworkz
force-pushed
the
submit_long_filenames
branch
from
acd81c6
to
8ecbafe
Compare
|
/submit |
|
Submitted as pull.28.v2.ffstaging.FFmpeg.1652653071.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
On the FFmpeg mailing list, nil-admirari@mailo.com wrote (reply to this): |
softworkz
force-pushed
the
submit_long_filenames
branch
from
8ecbafe
to
a526880
Compare
|
/submit |
|
Submitted as pull.28.v3.ffstaging.FFmpeg.1652736203.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
On the FFmpeg mailing list, Soft Works wrote (reply to this): |
softworkz
force-pushed
the
submit_long_filenames
branch
from
a526880
to
252ed89
Compare
|
/submit |
|
Submitted as pull.28.v4.ffstaging.FFmpeg.1653305371.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
User |
softworkz
force-pushed
the
submit_long_filenames
branch
from
252ed89
to
5313aee
Compare
|
/submit |
|
Submitted as pull.28.v5.ffstaging.FFmpeg.1653381808.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
User |
Signed-off-by: softworkz <softworkz@hotmail.com>
softworkz
force-pushed
the
submit_long_filenames
branch
from
5313aee
to
6f8d400
Compare
|
/submit |
|
/submit |
|
Submitted as pull.28.v7.ffstaging.FFmpeg.1653430851.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
On the FFmpeg mailing list, Martin Storsjö wrote (reply to this): |
Signed-off-by: softworkz <softworkz@hotmail.com>
stat is now re-mapped with long path support in os_support.h Signed-off-by: softworkz <softworkz@hotmail.com>
softworkz
force-pushed
the
submit_long_filenames
branch
from
0522fc2
to
e13c6b0
Compare
|
/submit |
|
Submitted as pull.28.v8.ffstaging.FFmpeg.1653557330.ffmpegagent@gmail.com To fetch this version into To fetch this version to local tag |
|
On the FFmpeg mailing list, Martin Storsjö wrote (reply to this): |
|
On the FFmpeg mailing list, Martin Storsjö wrote (reply to this): |
|
On the FFmpeg mailing list, nil-admirari@mailo.com wrote (reply to this): |
|
On the FFmpeg mailing list, Soft Works wrote (reply to this): |
|
On the FFmpeg mailing list, Martin Storsjö wrote (reply to this): |
|
On the FFmpeg mailing list, nil-admirari@mailo.com wrote (reply to this): |
|
On the FFmpeg mailing list, nil-admirari@mailo.com wrote (reply to this): |
|
On the FFmpeg mailing list, Martin Storsjö wrote (reply to this): |
|
On the FFmpeg mailing list, Soft Works wrote (reply to this): |
|
On the FFmpeg mailing list, Soft Works wrote (reply to this): |
|
/submit |
|
Error: e13c6b0 was already submitted |
|
Invalid author email in bd0a2ca: "4985349+softworkz@users.noreply.github.com" |
|
There is a merge commit in this Pull Request: Please rebase the branch and force-push. |
|
Merged into master |
|
@softworkz this causes build failed on win32 https://0x0.st/oMIX.log |
@nanake - yes, when USE_32BIT_TIME_T is specifified. To fix, you also need to apply this: #35 |
|
On the FFmpeg mailing list, nil-admirari@mailo.com wrote (reply to this): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset adds support for long file and directory paths on Windows.
The implementation follows the same logic that .NET is using internally,
with the only exception that it doesn't expand short path components
in 8.3 format. .NET does this as the same function is also used for other
purposes, but in our case, that's not required. Short (8.3) paths are working
as well with the extended path prefix, even when longer than 260.
Successfully tested:
I have kept the individual functions separate on purpose, to make it
easy to compare with the .NET impl.
(compilers should inlinie those anyway)
v2
v3
v4
v5
v6
v7
v8
cc: Soft Works softworkz@hotmail.com
cc: Hendrik Leppkes h.leppkes@gmail.com
cc: Martin Storsjö martin@martin.st