Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitstream filter support for A/53 Closed Captions #50

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tmm1
Copy link

@tmm1 tmm1 commented Feb 4, 2023

/cc MythTV/mythtv#364
/cc xbmc/xbmc#22605
/cc xbmc/xbmc#22603
/cc xbmc/xbmc#22333

cc: Aman Karmani aman@tmm1.net
cc: Eric Lindvall eric@5stops.com
cc: Mark Thompson sw@jkqxz.net
cc: David Engel david@istwok.net
cc: Scott Theisen scott.the.elm@gmail.com
cc: Miguel Borges de Freitas 92enen@gmail.com

fhvwy and others added 5 commits February 3, 2023 16:07
Supports closed captions, active format and bar data as defined by
SCTE 128 part 1 or A/53 part 4, suitable for use with both MPEG-2
and H.264.

Signed-off-by: Aman Karmani <aman@tmm1.net>
Signed-off-by: Aman Karmani <aman@tmm1.net>
Signed-off-by: Aman Karmani <aman@tmm1.net>
Signed-off-by: Aman Karmani <aman@tmm1.net>
Signed-off-by: Aman Karmani <aman@tmm1.net>
@tmm1
Copy link
Author

tmm1 commented Feb 4, 2023

/submit

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Feb 4, 2023

Submitted as pull.50.ffstaging.FFmpeg.1675471315.ffmpegagent@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-50/tmm1/cbs-misc-a53-v3-v1

To fetch this version to local tag pr-ffstaging-50/tmm1/cbs-misc-a53-v3-v1:

git fetch --no-tags https://github.com/ffstaging/FFmpeg tag pr-ffstaging-50/tmm1/cbs-misc-a53-v3-v1

@tmm1
Copy link
Author

tmm1 commented Feb 4, 2023

@softworkz fyi cc parsing didn't seem to work correctly here. none of the emails were cc'd on my submission

EDIT: maybe i was supposed to put them at the bottom not the top?

@softworkz
Copy link
Collaborator

@softworkz fyi cc parsing didn't seem to work correctly here. none of the emails were cc'd on my submission

EDIT: maybe i was supposed to put them at the bottom not the top?

Yes, they need to be at the bottom. The first message is what's being sent out as git "cover page" ( PATCH0/N ), so it normally starts with whatever you want to tell (or not :-) ).

There mustn't be a slash before the cc's. See here for an example: #18 (comment)

Finally, the CC's are actually meant to be filled  the CCs automatically based on who replied on the ML. You can modify them, for subsequent patch versions, but I'm not sure whether it works for the initial send.

@kmikita
Copy link

kmikita commented Mar 29, 2023

Thank you! It is very useful feature, want to see merged into master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants