count also 429 response codes if -sa (stop on all error cases) is used #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joohoi
requested changes
Dec 8, 2019
pkg/ffuf/job.go
Outdated
| @@ -267,6 +284,11 @@ func (j *Job) CheckStop() { | |||
| } | |||
|
|
|||
| } | |||
| if j.Config.StopOnAll && (float64(j.Count429)/float64(j.Counter) > 0.95) { | |||
There was a problem hiding this comment.
We could probably lower this threshold value a bit. If a service has rate limit of, let's say 1000 req / minute, the first 1000 would get through, and the errors would start accumulating after that. To hit this threshold in this scenario, there would have to be 20 001 429 responses after that.
delic
force-pushed
the
stop_on_too_many_429
branch
from
cc3ab1a
to
9de11bd
Compare
Co-Authored-By: Joona Hoikkala <joohoi@users.noreply.github.com>
Co-Authored-By: Joona Hoikkala <joohoi@users.noreply.github.com>
delic
force-pushed
the
stop_on_too_many_429
branch
from
9de11bd
to
fa6f840
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.