Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for using ranges in size, word count or status code matching/filtering #47

Merged
merged 5 commits into from Jun 27, 2019

Conversation

delic
Copy link
Contributor

@delic delic commented Jun 27, 2019

Resolves #45

Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one architectural change to request!

@@ -0,0 +1,38 @@
package filter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see this moved to the main library: pkg/ffuf, this way it could be used from outside of the filters as well in the future. WIth the current implementation trying to reference it from the main library would cause a cyclic dependency import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did things.

@joohoi
Copy link
Member

joohoi commented Jun 27, 2019

LGTM, thanks!

@joohoi joohoi merged commit 08c4cb4 into ffuf:master Jun 27, 2019
@delic delic deleted the feature45 branch July 8, 2019 19:51
SakiiR pushed a commit to SakiiR/ffuf that referenced this pull request Aug 28, 2019
…ching/filtering (ffuf#47)

* allow ranges on response size matching/filtering

* allow ranges on word count matching/filtering

* allow ranges on http status matching/filtering

* documentation update about using ranges in size, word count and status code filtering/matching

* moved valuerange code to ffuf main package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit results with with http response size range
2 participants