Change precedence of quiet and JSON output to favour JSON #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the long wait in the queue. LGTM and merging now. |
|
Thank you for the merge! :) |
joohoi
added a commit
that referenced
this pull request
Feb 3, 2023
* Changes precedence of quiet and JSON output to favour JSON * Adds JSON output precedence change to CHANGELOG; TomNomNom to CONTRIBUTORS --------- Co-authored-by: Joona Hoikkala <joohoi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty small change that enables something I think is useful.
At the moment if you want all three of:
stdoutstderrThere's no easy way to do it. If you redirect
stderrto/dev/nullyou lose the error messages, if you use-s/silent/quiet mode you lose the JSON output.This change in precedence allows you to use both the
-sand-jsonflags to achieve the above, and shouldn't break any existing use-cases as the-jsonflag currently does nothing if you're also using the-sflag.