Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow unused wordlist in config file #652

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

Hazegard
Copy link
Contributor

This is an attempt to fix issue #572.

The current fix just print the error message to stderr instead of adding it to the Multierror defined.
I am open to better alternatives 😁

I also had to remove unused worldlist in the Config.InputProviders. Otherwise, unused wordlists are still considered as used (in the reports for instance).

@maa-x
Copy link

maa-x commented Jun 7, 2023

Thanks for the PR. Any ideas why this PR is being ignored? It would significantly improve my workflow when using ffuf.

@n3rada
Copy link

n3rada commented Sep 4, 2023

Is the maintainer consciously ignoring this Pull Request?

@bsysop
Copy link
Collaborator

bsysop commented Sep 4, 2023

Hi everyone,

@n3rada, "consciously ignoring" is not the most appropriate for Open Source tools :), Things in Open Source are done when possible and this will be reviewed as soon as possible.

@MaxIsMyName an option for you is building the code locally using Golang go build and running it with the PR.

@joohoi
Copy link
Member

joohoi commented Sep 4, 2023 via email

@n3rada
Copy link

n3rada commented Sep 4, 2023

Forgive me for the "conscientiousness". I meant that you may didn't want to implement it that way at all and therefore ignored the request.

Personally, I use ffuf in preference to other tools, so I can only respect your work and your choice of direction. I'm pleased to see that you're going to make these changes. Thank you for your promptness!

@joohoi
Copy link
Member

joohoi commented Sep 15, 2023

I ended up merging the pencode feature, but didn't get to the point where the wordlists and keywords should be managed. That's going to be something for the future. So contrary to my previous message, I'm going to accept and merge this pull request so it makes it to the upcoming release. Thanks for the PR!

@joohoi joohoi merged commit a7dea16 into ffuf:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants