Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write a finishing newline in silent mode #677

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

Nirusu
Copy link
Contributor

@Nirusu Nirusu commented May 10, 2023

Description

When running ffuf in silent mode, a new line is still written on every line at the end of a run of ffuf.
While this looks fine if there are any matches, it will just spam empty new lines whenever:

  • No matches are found
  • If you redirect stdout but keep stderr on console

Piping ffuf multiple times with different targets, this approx. looks like this:

Screen.Recording.2023-05-10.at.10.25.55.mov

Thus, let's remove printing the new line when in silent mode.

Additonally

  • If this is the first time you are contributing to ffuf, add your name to CONTRIBUTORS.md.
    The file should be alphabetically ordered.
  • Add a short description of the fix to CHANGELOG.md

-> I skipped since I thought this change is too insignificant.

@joohoi
Copy link
Member

joohoi commented Sep 15, 2023

Thanks for the PR, merging

@joohoi joohoi merged commit 8453335 into ffuf:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants