Match both %ext% and %EXT% in DirSearch compatibility mode #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
joohoi
requested changes
Oct 20, 2019
pkg/input/wordlist.go
Outdated
| @@ -98,6 +98,11 @@ func (w *WordlistInput) readFile(path string) error { | |||
| contnt := strings.Replace(reader.Text(), "%EXT%", ext, -1) | |||
| data = append(data, []byte(contnt)) | |||
| } | |||
| } else if strings.Index(reader.Text(), "%ext%") != -1 { | |||
| for _, ext := range w.config.Extensions { | |||
| contnt := strings.Replace(reader.Text(), "%ext%", ext, -1) | |||
There was a problem hiding this comment.
I would rather see the original replace action changed to case insensitive regex replace. This way it would match possible typos %Ext% etc. as well.
There was a problem hiding this comment.
better now? I haven't really written any go before
joohoi
requested changes
Oct 24, 2019
| @@ -91,11 +91,13 @@ func (w *WordlistInput) readFile(path string) error { | |||
|
|
|||
| var data [][]byte | |||
| reader := bufio.NewScanner(file) | |||
| re := regexp.MustCompile(`(?i)%ext%`) | |||
There was a problem hiding this comment.
For readability, this should get moved to the if w.config.DirSearchCompat... block
There was a problem hiding this comment.
I think outside the loop is better so the regex doesn't get created for every line in the input
There was a problem hiding this comment.
Absolutely, thanks for clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.