Add options to specify header level and version prefix #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const start_of_release = (!!line.match("^#+ \\[[0-9]") || (prerelease === 'true' && !!line.match("^#+ \\[Unreleased\\]"))) | ||
| let header_match = (!!line.match(level_match_regex)) | ||
| let headerup_match = (!!line.match(levelup_match_regex)) | ||
| let start_of_release = (!!line.match(level_match_regex + version_match_regex) || (prerelease === 'true' && !!line.match(level_match_regex + unreleases_match_regex))) |
Check failure
Code scanning / CodeQL
Regular expression injection High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in our project, the
CHANGELOG.mdfile deviates a little from what is expected by the current github actions script. In particular, the header level of the version specific changelog entries isH3instead ofH2. In addition, the header not only states the version number (x.y.z), but contains a prefix string, such that each line looks like:[Version x.y.z]
instead of just
[x.y.z]
To account for these deviations, I've modified your script to allow for additional, optional arguments:
header_levelinputversion_prefixinputI thought, it might be useful for others, so I want to share. The additional inputs are documented and examples are given in
README.mdas well.It would be nice, if it would be integrated into your mainstream release.
Cheers,
RaumZeit